From b15bb9052d82d729632a9c292847dc066b4a0f54 Mon Sep 17 00:00:00 2001 From: furtest Date: Tue, 5 May 2026 11:25:52 +0200 Subject: [PATCH] synchroniser : remove wait for foreground links update The run function already waits for the command to finish and wheter or not it actually runs in the background is handled before using & and nohup. Furthermore it also appears that this code might be broken. So there is only one thing to do : remove it --- src/unisync/synchroniser.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/unisync/synchroniser.py b/src/unisync/synchroniser.py index 1f4ee10..ae51731 100644 --- a/src/unisync/synchroniser.py +++ b/src/unisync/synchroniser.py @@ -279,12 +279,12 @@ class Synchroniser: link_background_wrapper ] - link_update_process = subprocess.run(command, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL) - - if not background: - print("Starting links update.") - link_update_process.wait() - print("Done") + print("Updating links") + subprocess.run(command, + stdout=subprocess.DEVNULL, + stderr=subprocess.DEVNULL, + check=False + ) def mount_remote_dir(self): """Mounts the remote directory to make the local links work.